Update circleDetection.gsql #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaning up previously visited list accumulators greatly improves memory usage for this algorithm. This is done by removing the edgeTupleList from the source in the post-Accum step as the new paths are already forwarded to the next vertexes in the path. To my understanding, at that point, there is no need to store the paths in source vertex.
|
@louisza Thank you for your contribution! Our algorithm team will review today and get back to you with any questions and/or go forwards with the pull request. We appreciate your input and are excited to have you here in the community! |
|
Please remove me
Sincerely,
Jeff Haber
Sent from my iPhone
… On Oct 28, 2020, at 5:53 AM, HerkTG ***@***.***> wrote:
@louisza Thank you for your contribution! Our algorithm team will review today and get back to you with any questions and/or go forwards with the pull request. We appreciate your input and are excited to have you here in the community!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@JeffHMB you will need to "unstar" tigergraph ecosys if you would not like to receive updates. Unfortunately, you will need to log into your account to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimise memory usage of the algorithm - (based on my experience with this algorithm eating up 10x memory compared to idle state)
Cleaning up previously visited list accumulators greatly improves memory usage for this algorithm. This is done by removing the edgeTupleList from the source in the post-Accum step as the new paths are already forwarded to the next vertexes in the path. To my understanding, at that point, there is no need to store the paths in source vertex.